Page MenuHomePhabricator

The poop emoji (U+1F4A9) breaks differential
AbandonedPublic

Authored by NorthIsUp on Nov 1 2013, 9:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 19, 5:50 PM
Unknown Object (File)
Sun, Nov 15, 5:01 AM
Unknown Object (File)
Fri, Nov 13, 8:49 PM
Unknown Object (File)
Wed, Nov 11, 9:34 PM
Unknown Object (File)
Wed, Nov 11, 9:29 PM
Unknown Object (File)
Sun, Nov 8, 5:12 AM
Unknown Object (File)
Sun, Nov 8, 2:12 AM
Unknown Object (File)
Fri, Nov 6, 12:06 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4045: Store diffs as binary, not UTF-8
Test Plan

not a real diff

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Although for the special case of diffs themselves (vs comment text, titles, summaries, etc.) I think we're going to move toward binary storage + runtime mangling.

Just pushing this out of my queue; see T4045 for strategy if you're feeling brave about fixing this.