Page MenuHomePhabricator

Mark IMPORTED_CHANGE more consistently
ClosedPublic

Authored by epriestley on Nov 1 2013, 3:55 PM.
Tags
None
Referenced Files
F13844225: D7470.diff
Fri, Sep 27, 5:35 AM
Unknown Object (File)
Fri, Aug 30, 7:36 AM
Unknown Object (File)
Thu, Aug 29, 8:07 AM
Unknown Object (File)
Wed, Aug 28, 10:56 PM
Unknown Object (File)
Aug 18 2024, 11:59 AM
Unknown Object (File)
Aug 14 2024, 5:22 AM
Unknown Object (File)
Aug 14 2024, 5:18 AM
Unknown Object (File)
Aug 14 2024, 5:17 AM
Subscribers

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rPd1649d176f67: Mark IMPORTED_CHANGE more consistently
Summary

See https://github.com/facebook/phabricator/issues/425. There are some ways that the change parsers may not reach finishParse(), but we now need them to in order to mark the commit imported, advance the progress bar, and eventually kick the repository out of IMPORTING status.

Take all the copy/pasted code in the parsers and move it into the parent. Specifically, this is:

  • Printing a status message about starting a parse;
  • checking for bad commits;
  • queueing the next parse stage; and
  • marking the import step complete.
Test Plan

Used reparse.php --change to reparse Git, SVN and Mercurial repos.

Diff Detail

Branch
alwaysmark
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

epriestley updated this revision to Unknown Object (????).Nov 1 2013, 3:57 PM

Smaller diff.