Page MenuHomePhabricator
Differential D7427

Don't pull updates for repositories marked as hosted
ClosedPublic
Actions

Authored by epriestley on Oct 26 2013, 9:46 PM.
Tags
None
Referenced Files
F15517664: D7427.diff
Sat, Apr 19, 7:35 AM
F15506570: D7427.diff
Tue, Apr 15, 12:19 PM
F15478716: D7427.id16754.diff
Tue, Apr 8, 2:25 AM
F15472332: D7427.diff
Sat, Apr 5, 12:42 PM
F15431957: D7427.diff
Mon, Mar 24, 3:31 PM
F15413447: D7427.id.diff
Mar 19 2025, 6:48 PM
F15302764: D7427.diff
Mar 5 2025, 9:09 PM
Unknown Object (File)
Feb 27 2025, 3:22 AM
View All Files
Subscribers
aran

Details

Reviewers
hach-que
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP0965f0041a5c: Don't pull updates for repositories marked as hosted
Summary
  • Don't try to pull hosted repos.
  • Also, fix the --verbose + --trace interaction for bin/repository.
  • Also, fix a couple of unit tests which got tweaked earlier.
Test Plan
$ ./bin/repository pull GTEST --verbose
Pulling 'GTEST'...
Repository "GTEST" is hosted, so Phabricator does not pull updates for it.
Done.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que accepted this revision.Oct 26 2013, 10:21 PM

Test plan does work as expected, but there's still quite a few exceptions and errors occurring in the daemons due to tracking configuration.

See P962 and P963 for related exceptions.

epriestley closed this revision.Oct 29 2013, 10:33 PM

Closed by commit rP0965f0041a5c (authored by @epriestley).

Revision Contents
Changeset List

Diff 16754

View Options

src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryEngine.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

Loading...
View Options

src/applications/repository/engine/__tests__/PhabricatorWorkingCopyTestCase.php

Loading...
Phabricator · Built by Phacility