Page MenuHomePhabricator
Differential D7427

Don't pull updates for repositories marked as hosted
ClosedPublic
Actions

Authored by epriestley on Oct 26 2013, 9:46 PM.
Tags
None
Referenced Files
F14033217: D7427.id16754.diff
Sat, Nov 9, 5:06 PM
F14033216: D7427.id16720.diff
Sat, Nov 9, 5:06 PM
F14033215: D7427.id.diff
Sat, Nov 9, 5:05 PM
F14020424: D7427.diff
Wed, Nov 6, 12:33 AM
F14003273: D7427.id16754.diff
Sat, Oct 26, 4:17 AM
F13983595: D7427.id16720.diff
Sun, Oct 20, 7:29 AM
F13978818: D7427.diff
Sat, Oct 19, 1:07 AM
Unknown Object (File)
Oct 5 2024, 5:35 PM
View All Files
Subscribers
aran

Details

Reviewers
hach-que
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP0965f0041a5c: Don't pull updates for repositories marked as hosted
Summary
  • Don't try to pull hosted repos.
  • Also, fix the --verbose + --trace interaction for bin/repository.
  • Also, fix a couple of unit tests which got tweaked earlier.
Test Plan
$ ./bin/repository pull GTEST --verbose
Pulling 'GTEST'...
Repository "GTEST" is hosted, so Phabricator does not pull updates for it.
Done.

Diff Detail

Branch
redit16
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

hach-que accepted this revision.Oct 26 2013, 10:21 PM

Test plan does work as expected, but there's still quite a few exceptions and errors occurring in the daemons due to tracking configuration.

See P962 and P963 for related exceptions.

epriestley closed this revision.Oct 29 2013, 10:33 PM

Closed by commit rP0965f0041a5c (authored by @epriestley).

Revision Contents
Changeset List

Diff 16720

View Options

src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryEngine.php

Loading...
View Options

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

Loading...
View Options

src/applications/repository/engine/__tests__/PhabricatorWorkingCopyTestCase.php

Loading...
Phabricator · Built by Phacility