Page MenuHomePhabricator

Serve Git reads over HTTP
ClosedPublic

Authored by epriestley on Oct 26 2013, 7:21 PM.
Tags
None
Referenced Files
F14033207: D7423.id16751.diff
Sat, Nov 9, 5:04 PM
F14033205: D7423.id16716.diff
Sat, Nov 9, 5:04 PM
F14033204: D7423.id.diff
Sat, Nov 9, 5:04 PM
F14020417: D7423.diff
Wed, Nov 6, 12:32 AM
F14011246: D7423.id.diff
Thu, Oct 31, 10:02 PM
F13993368: D7423.id16716.diff
Tue, Oct 22, 10:26 PM
F13971243: D7423.diff
Thu, Oct 17, 12:28 PM
Unknown Object (File)
Sep 25 2024, 11:26 AM
Subscribers

Details

Reviewers
hach-que
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP7d9dfb561dd5: Serve Git reads over HTTP
Summary

Mostly ripped from D7391. No writes yet.

Test Plan

Ran git clone against a local over HTTP, got a clone.

Diff Detail

Branch
redit12
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Assuming this is only supposed to work for public repositories at the moment (setting the view policy to anything else results in authentication failure), then this looks reasonably good.

src/applications/diffusion/controller/DiffusionController.php
415

git-http-backend is often not in PATH; instead it sits under /usr/libexec/git or /usr/lib/git. At some point we'll need a setup check to detect if git-http-backend is not available and warn the user that they might need to set environment.append-paths correctly.