Make remarkup rules runtime-pluggable in a reasonable way
ClosedPublic
Actions

Authored by epriestley on Oct 24 2013, 11:28 PM.

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP9e87172166a1: Make remarkup rules runtime-pluggable in a reasonable way

Summary

Gets rid of some old Differential-specific nonsense and replaces it with general runtime-pluggable Remarkup rules.

Facebook: This removes two options which may be in use. Have any classes being added via config here just subclass the new abstract bases instead. This should take 5 seconds to fix. You can adjust order by overriding getPriority() on the rules, if necessary.

Test Plan

See comments.

Diff Detail

Branch

plugremarkup

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

I added this rule:

<?php

final class CustomInlineCodeRule extends PhabricatorRemarkupCustomInlineRule {

  public function apply($text) {
    return preg_replace_callback(
      '(<code>(.*?)</code>)s',
      array($this, 'markupInlineCodeBlock'),
      $text);
  }

  public function markupInlineCodeBlock($matches) {
    $engine = $this->getEngine();

    $text = $matches[1];

    $highlighter = new PhutilDefaultSyntaxHighlighterEngine();
    $highlighter->setConfig(
      'pygments.enabled',
      $engine->getConfig('pygments.enabled'));

    $lang = PhutilLanguageGuesser::guessLanguage($text);
    if (!$lang) {
      $lang = nonempty(
        $engine->getConfig('phutil.codeblock.language-default'),
        'php');
    }

    $source_body = phutil_tag(
      'span',
      array(
        'class' => 'remarkup-code PhabricatorMonospaced',
        'style' => 'white-space: pre-wrap; background: #fdfae7;',
      ),
      PhutilSafeHTML::applyFunction(
        'rtrim',
        $highlighter->highlightSource($lang, $text)));

    return $engine->storeText($source_body);
  }

}