Paths

Table of Contentst

Fix chatlog application query integration
ClosedPublic
Actions

Authored by epriestley on Oct 22 2013, 6:41 PM.

Tags

None

Referenced Files

	F14045134: D7379.id16621.diff
	Wed, Nov 13, 1:31 AM

	F14035650: D7379.id16618.diff
	Sun, Nov 10, 7:00 AM

	F14035275: D7379.diff
	Sun, Nov 10, 5:15 AM

	F13966342: D7379.diff
	Wed, Oct 16, 7:39 AM

	Unknown Object (File)
	Oct 11 2024, 10:32 AM

	Unknown Object (File)
	Oct 3 2024, 12:53 PM

	Unknown Object (File)
	Oct 3 2024, 12:49 PM

	Unknown Object (File)
	Oct 3 2024, 12:48 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP7dd31a16d973: Fix chatlog application query integration

Summary

class_exists() is case-insensitive, but PhabricatorApplication::getByClass() is not.

Test Plan

Fixed unit test to fail, then fixed code to pass unit test.

Diff Detail

Branch

queryapp

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

btrahan accepted this revision.Oct 22 2013, 8:39 PM

Closed by commit rP7dd31a16d973 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

chatlog/

PhabricatorChatLogChannelQuery.php

2 lines

PhabricatorChatLogQuery.php

2 lines

policy/

__tests__/

PhabricatorPolicyTestCase.php

2 lines

Diff 16618

View Options

src/applications/chatlog/PhabricatorChatLogChannelQuery.php

View Options

src/applications/chatlog/PhabricatorChatLogQuery.php

View Options

src/applications/policy/tests/PhabricatorPolicyTestCase.php

Fix chatlog application query integrationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16618

src/applications/chatlog/PhabricatorChatLogChannelQuery.php

src/applications/chatlog/PhabricatorChatLogQuery.php

src/applications/policy/__tests__/PhabricatorPolicyTestCase.php

Fix chatlog application query integration
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/policy/tests/PhabricatorPolicyTestCase.php