Page MenuHomePhabricator

Modernize policies in Paste and Macro
ClosedPublic

Authored by epriestley on Oct 15 2013, 12:30 AM.
Tags
None
Referenced Files
F18745559: D7317.diff
Fri, Oct 3, 7:54 AM
F18671050: D7317.id16482.diff
Thu, Sep 25, 2:33 AM
F18652100: D7317.diff
Sun, Sep 21, 6:38 AM
F18651572: D7317.diff
Sun, Sep 21, 4:41 AM
F18405140: D7317.diff
Aug 29 2025, 11:08 PM
F18383882: D7317.id16482.diff
Aug 28 2025, 11:32 PM
F18350304: D7317.id.diff
Aug 26 2025, 7:30 PM
F18349241: D7317.diff
Aug 26 2025, 6:02 PM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
T603: Support permissions/policies in all Phabricator applications
Commits
Restricted Diffusion Commit
rP8c1c6fec5ac9: Modernize policies in Paste and Macro
Summary

Ref T603. Fixes T2823. This updates Paste and Macro.

  • Paste
    • Added default view policy.
    • I didn't add a "create" policy, since I can't come up with any realistic scenario where you'd give users access to pastes but not let them create them.
  • Macro
    • Added a "manage" policy, which covers creating and editing macros. This lets an install only allow "People With An Approved Sense of Humor" or whatever to create macros.
    • Removed the "edit" policy, since giving individual users access to specific macros doesn't make much sense to me.
    • Changed the view policy to the "most public" policy the install allows.
    • Added view policy information to the header.

Also fix a couple of minor things in Maniphest.

Test Plan
  • Set Paste policy, created pastes via web and Conduit, saw they got the right default policies.
  • Set Macro policy, tried to create/edit macros with valid and unauthorized users.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped