Page MenuHomePhabricator

Allow "Custom" policies to be selected in the policy control
ClosedPublic

Authored by epriestley on Oct 14 2013, 12:49 AM.
Tags
None
Referenced Files
F13233236: D7300.id16480.diff
Tue, May 21, 2:07 AM
F13226814: D7300.id16430.diff
Sun, May 19, 11:33 PM
F13202477: D7300.id16481.diff
Tue, May 14, 10:43 PM
F13199090: D7300.id16481.diff
Mon, May 13, 11:27 AM
F13191352: D7300.id16430.diff
Sat, May 11, 7:42 PM
F13190930: D7300.id.diff
Sat, May 11, 3:39 PM
F13190851: D7300.diff
Sat, May 11, 2:37 PM
F13190010: D7300.id16480.diff
Sat, May 11, 6:58 AM
Subscribers

Details

Summary

Ref T603. When a user selects "Custom", we pop open the rules dialog and let them create a new rule or edit the existing rule.

Test Plan

Set some objects to have custom policies.

Diff Detail

Branch
papply9
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

Any diff with JX.bag is a winner

(I'm going to hold this for a little bit since I want to improve the endpoint's ability to reduce/simplify nonsense policies, like "user" policies with no actual value, and maybe add a bit more error checking.)

epriestley updated this revision to Unknown Object (????).Oct 14 2013, 11:59 PM
  • Clean up a couple of minor things while testing against the new master.