Don't try to activate disabled items in dropdown menus
ClosedPublic
Actions

Authored by epriestley on Oct 14 2013, 12:26 AM.

Tags

None

Referenced Files

	F14057324: D7293.id16423.diff
	Sun, Nov 17, 2:17 AM

	F14002344: D7293.diff
	Fri, Oct 25, 6:07 PM

	F14000882: D7293.id16448.diff
	Fri, Oct 25, 2:00 AM

	F14000726: D7293.diff
	Fri, Oct 25, 12:05 AM

	F13981091: D7293.diff
	Sat, Oct 19, 2:12 PM

	F13974450: D7293.id.diff
	Fri, Oct 18, 5:36 AM

	Unknown Object (File)
	Oct 3 2024, 9:52 AM

	Unknown Object (File)
	Oct 3 2024, 9:48 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan
chad
va.multimoney

Commits

Restricted Diffusion Commit
rP994823524b57: Don't try to activate disabled items in dropdown menus

Summary

Fixes an issue where the user could click a disabled dropdown menu item and get an exception or some other nonsense. Instead, just don't activate anything.

Test Plan

Clicked a disabled header, like "Members of project" in the policy dropdown.

Diff Detail

Branch

papply2

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

fhmgh

Although I'm sure your review was exceptionally through, I'll wait for @btrahan to take a look too.

chad accepted this revision.Oct 14 2013, 3:56 PM

Closed by commit rP994823524b57 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__celerity_resource_map__.php

84 lines

webroot/

rsrc/

js/

core/

DropdownMenu.js

6 lines

Diff 16423

View Options

src/__celerity_resource_map__.php