Page MenuHomePhabricator
Differential D7280

Improve pagination in ChatLog application
ClosedPublic
Actions

Authored by asherkin on Oct 10 2013, 2:02 AM.
Tags
None
Referenced Files
F14475649: D7280.diff
Fri, Dec 27, 8:13 PM
Unknown Object (File)
Tue, Dec 17, 7:37 AM
Unknown Object (File)
Mon, Dec 9, 4:12 AM
Unknown Object (File)
Mon, Dec 9, 4:12 AM
Unknown Object (File)
Mon, Dec 9, 4:12 AM
Unknown Object (File)
Fri, Nov 29, 9:29 AM
Unknown Object (File)
Nov 19 2024, 9:14 PM
Unknown Object (File)
Nov 16 2024, 9:31 AM
View All Files
Subscribers
aran
chad
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPff4fa1885b4e: Improve pagination in ChatLog application
Summary
  • Add an extra paginator at the top.
  • Add a link to jump to the bottom (where the latest messages are).
  • Align paginators with edge of content rather than the page.
Test Plan

Looked at the chatlog.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad added a comment.Oct 10 2013, 5:03 AM

{F66608,size=full}

epriestley accepted this revision.Oct 10 2013, 11:52 AM

Cool, this seems unambiguously better to me, and puts us a step closer to some kind of fancy Ajax version. Thanks!

epriestley closed this revision.Oct 10 2013, 11:52 AM

Closed by commit rPff4fa1885b4e (authored by @asherkin, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
chatlog/
controller/
71 lines
view/
control/
68 lines
webroot/
rsrc/
css/
application/
chatlog/
24 lines

Diff 16392

View Options

src/__celerity_resource_map__.php

Loading...
View Options

src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php

Loading...
View Options

src/view/control/AphrontCursorPagerView.php

Loading...
View Options

webroot/rsrc/css/application/chatlog/chatlog.css

Loading...
Phabricator · Built by Phacility