UX on this could probably be better 'disabled' crumbs don't appear to have any visible difference, and the policy error has to load the /create page rather than being a modal - not sure on the way to fix these.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rP8cc64a96789b: Add a 'create' policy to Project
Tried to create a project with and without access, saw suitable error.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Looks perfect to me, thanks! See inline for one weird trick to create dialogs. We'll make "disabled" look meaningfully different at some point, too.
{F66779}
| src/applications/project/controller/PhabricatorProjectController.php | ||
|---|---|---|
| 34–37 | To get a dialog, do: ->setWorkflow(!$can_create) This basically means "Use JX.Workflow (which does dialogs) to follow this link if the user doesn't have create permission". I'll add this in the pull. | |