Differential D21742 Diff 51827 src/lint/linter/xhpast/rules/ArcanistSelfMemberReferenceXHPASTLinterRule.php
Changeset View
Changeset View
Standalone View
Standalone View
src/lint/linter/xhpast/rules/ArcanistSelfMemberReferenceXHPASTLinterRule.php
| Show All 36 Lines | foreach ($class_declarations as $class_declaration) { | ||||
| foreach ($closures as $closure) { | foreach ($closures as $closure) { | ||||
| if ($class_ref->isDescendantOf($closure)) { | if ($class_ref->isDescendantOf($closure)) { | ||||
| $in_closure = true; | $in_closure = true; | ||||
| break; | break; | ||||
| } | } | ||||
| } | } | ||||
| if (version_compare($this->version, '5.4.0', '>=') || !$in_closure) { | $version_target = $this->version; | ||||
| if (!$version_target) { | |||||
| $version_target = phpversion(); | |||||
| } | |||||
| if (version_compare($version_target, '5.4.0', '>=') || !$in_closure) { | |||||
| $this->raiseLintAtNode( | $this->raiseLintAtNode( | ||||
| $class_ref, | $class_ref, | ||||
| pht( | pht( | ||||
| 'Use `%s` for local static member references.', | 'Use `%s` for local static member references.', | ||||
| 'self::'), | 'self::'), | ||||
| 'self'); | 'self'); | ||||
| } | } | ||||
| } | } | ||||
| } | } | ||||
| } | } | ||||
| } | } | ||||
| } | } | ||||