Differential D21598 Diff 51422 src/applications/repository/storage/PhabricatorRepositoryAuditRequest.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/repository/storage/PhabricatorRepositoryAuditRequest.php
Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines | public function attachCommit(PhabricatorRepositoryCommit $commit) { | ||||
$this->commit = $commit; | $this->commit = $commit; | ||||
return $this; | return $this; | ||||
} | } | ||||
public function getCommit() { | public function getCommit() { | ||||
return $this->assertAttached($this->commit); | return $this->assertAttached($this->commit); | ||||
} | } | ||||
public function isActiveAudit() { | |||||
epriestley: After these changes, this just means "is not-resigned", and we already have "isResigned()" to… | |||||
switch ($this->getAuditStatus()) { | |||||
case PhabricatorAuditStatusConstants::NONE: | |||||
case PhabricatorAuditStatusConstants::AUDIT_NOT_REQUIRED: | |||||
case PhabricatorAuditStatusConstants::RESIGNED: | |||||
case PhabricatorAuditStatusConstants::CLOSED: | |||||
case PhabricatorAuditStatusConstants::CC: | |||||
return false; | |||||
} | |||||
return true; | |||||
} | |||||
public function isInteresting() { | |||||
switch ($this->getAuditStatus()) { | |||||
case PhabricatorAuditStatusConstants::NONE: | |||||
case PhabricatorAuditStatusConstants::AUDIT_NOT_REQUIRED: | |||||
return false; | |||||
} | |||||
return true; | |||||
} | |||||
Done Inline ActionsAfter these changes, all audit requests are "interesting". epriestley: After these changes, all audit requests are "interesting". | |||||
public function isResigned() { | public function isResigned() { | ||||
switch ($this->getAuditStatus()) { | switch ($this->getAuditStatus()) { | ||||
case PhabricatorAuditStatusConstants::RESIGNED: | case PhabricatorAuditStatusConstants::RESIGNED: | ||||
return true; | return true; | ||||
} | } | ||||
return false; | return false; | ||||
} | } | ||||
Show All 24 Lines |
After these changes, this just means "is not-resigned", and we already have "isResigned()" to test for that.