Differential D20507 Diff 48936 src/applications/differential/xaction/DifferentialRevisionTitleTransaction.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/differential/xaction/DifferentialRevisionTitleTransaction.php
Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Lines | public function validateTransactions($object, array $xactions) { | ||||
return $errors; | return $errors; | ||||
} | } | ||||
public function getTransactionTypeForConduit($xaction) { | public function getTransactionTypeForConduit($xaction) { | ||||
return 'title'; | return 'title'; | ||||
} | } | ||||
public function getFieldValuesForConduit($object, $data) { | public function getFieldValuesForConduit($xaction, $data) { | ||||
amckinley: Does this (and the change in `DifferentialRevisionUpdateTransaction`) reflect an API change… | |||||
return array( | return array( | ||||
'old' => $object->getOldValue(), | 'old' => $xaction->getOldValue(), | ||||
'new' => $object->getNewValue(), | 'new' => $xaction->getNewValue(), | ||||
); | ); | ||||
} | } | ||||
} | } |
Does this (and the change in DifferentialRevisionUpdateTransaction) reflect an API change that happened at some point, or were these arguments just named incorrectly from the beginning?