Differential D20006 Diff 47807 src/applications/settings/panel/PhabricatorTokensSettingsPanel.php

Changeset View

Standalone View

src/applications/settings/panel/PhabricatorTokensSettingsPanel.php

	<?php			<?php

	final class PhabricatorTokensSettingsPanel extends PhabricatorSettingsPanel {			final class PhabricatorTokensSettingsPanel extends PhabricatorSettingsPanel {

	public function getPanelKey() {			public function getPanelKey() {
	return 'tokens';			return 'tokens';
	}			}

	public function getPanelName() {			public function getPanelName() {
	return pht('Temporary Tokens');			return pht('Temporary Tokens');
	}			}

				public function getPanelMenuIcon() {
				return 'fa-ticket';
				}
				amckinleyUnsubmitted Not Done Inline Actions This is the only one I'm a little on the fence about, but I guess you're trying to make these unique and you don't want to re-use `fa-key`? Maybe `fa-clock` would work better? This is 100% USDA-certified bike shedding, but I feel like `fa-hourglass` connotes a thing that the user is waiting on to finish so they can get back to work, not a thing that is already good to go. amckinley: This is the only one I'm a little on the fence about, but I guess you're trying to make these…

	public function getPanelGroupKey() {			public function getPanelGroupKey() {
	return PhabricatorSettingsLogsPanelGroup::PANELGROUPKEY;			return PhabricatorSettingsLogsPanelGroup::PANELGROUPKEY;
	}			}

	public function processRequest(AphrontRequest $request) {			public function processRequest(AphrontRequest $request) {
	$viewer = $request->getUser();			$viewer = $request->getUser();

	$tokens = id(new PhabricatorAuthTemporaryTokenQuery())			$tokens = id(new PhabricatorAuthTemporaryTokenQuery())
	▲ Show 20 Lines • Show All 65 Lines • Show Last 20 Lines