Differential D19714 Diff 47128 src/__tests__/PhutilLibraryTestCase.php

Changeset View

Standalone View

src/tests/PhutilLibraryTestCase.php

<?php		<?php

/**		/**
* @concrete-extensible		* @concrete-extensible
*/		*/
class PhutilLibraryTestCase extends PhutilTestCase {		class PhutilLibraryTestCase extends PhutilTestCase {

/**		/**
* This is more of an acceptance test case instead of a unit test. It verifies		* This is more of an acceptance test case instead of a unit test. It verifies
* that all symbols can be loaded correctly. It can catch problems like		* that all symbols can be loaded correctly. It can catch problems like
* missing methods in descendants of abstract base classes.		* missing methods in descendants of abstract base classes.
*/		*/
public function testEverythingImplemented() {		public function testEverythingImplemented() {
		$this->assertSkipped('TOOLSETS: Many workflows are missing methods.');
		amckinleyUnsubmitted Not Done Inline Actions I guess a skipped test is pretty visible, and grepping for "TOOLSETS" will find this too. amckinley: I guess a skipped test is pretty visible, and grepping for "TOOLSETS" will find this too.
		epriestleyAuthorUnsubmitted Done Inline Actions Yeah. I've also made skipped tests more visible in the new code -- they're always summarized at the bottom of the output. epriestley: Yeah. I've also made skipped tests more visible in the new code -- they're always summarized at…

id(new PhutilSymbolLoader())		id(new PhutilSymbolLoader())
->setLibrary($this->getLibraryName())		->setLibrary($this->getLibraryName())
->selectAndLoadSymbols();		->selectAndLoadSymbols();
$this->assertTrue(true);		$this->assertTrue(true);
}		}

/**		/**
* This is more of an acceptance test case instead of a unit test. It verifies		* This is more of an acceptance test case instead of a unit test. It verifies
▲ Show 20 Lines • Show All 65 Lines • ▼ Show 20 Lines	class PhutilLibraryTestCase extends PhutilTestCase {


/**		/**
* This is more of an acceptance test case instead of a unit test. It verifies		* This is more of an acceptance test case instead of a unit test. It verifies
* that methods in subclasses have the same visibility as the method in the		* that methods in subclasses have the same visibility as the method in the
* parent class.		* parent class.
*/		*/
public function testMethodVisibility() {		public function testMethodVisibility() {
		$this->assertSkipped('TOOLSETS: Many workflows currently have failures.');

$symbols = id(new PhutilSymbolLoader())		$symbols = id(new PhutilSymbolLoader())
->setLibrary($this->getLibraryName())		->setLibrary($this->getLibraryName())
->selectSymbolsWithoutLoading();		->selectSymbolsWithoutLoading();

$classes = array();		$classes = array();
foreach ($symbols as $symbol) {		foreach ($symbols as $symbol) {
if ($symbol['type'] == 'class') {		if ($symbol['type'] == 'class') {
$classes[$symbol['name']] = new ReflectionClass($symbol['name']);		$classes[$symbol['name']] = new ReflectionClass($symbol['name']);
▲ Show 20 Lines • Show All 89 Lines • Show Last 20 Lines