Differential D19651 Diff 46971 src/applications/search/engine/PhabricatorSearchEngineAPIMethod.php

Changeset View

Standalone View

src/applications/search/engine/PhabricatorSearchEngineAPIMethod.php

Show First 20 Lines • Show All 224 Lines • ▼ Show 20 Lines	foreach ($fields as $field) {
if ($constants) {		if ($constants) {
$constant_lists[] = $this->buildRemarkup(		$constant_lists[] = $this->buildRemarkup(
pht(		pht(
'Constants supported by the `%s` constraint:',		'Constants supported by the `%s` constraint:',
'statuses'));		'statuses'));

$constants_rows = array();		$constants_rows = array();
foreach ($constants as $constant) {		foreach ($constants as $constant) {
		if ($constant->getIsDeprecated()) {
		$icon = id(new PHUIIconView())
		->setIcon('fa-exclamation-triangle', 'red');
		} else {
		$icon = null;
		amckinleyUnsubmitted Not Done Inline Actions Should we add a little icon in this column to match the appearance of frozen conduit methods? (This is is kind of an actual consistency issue). Or alternately, add 💚vs ❌on every row? (This is just bike-shedding). amckinley: Should we add a little icon in this column to match the appearance of frozen conduit methods?
		}

$constants_rows[] = array(		$constants_rows[] = array(
$constant->getKey(),		$constant->getKey(),
		array(
		$icon,
		' ',
$constant->getValue(),		$constant->getValue(),
		),
);		);
}		}

$constants_table = id(new AphrontTableView($constants_rows))		$constants_table = id(new AphrontTableView($constants_rows))
->setHeaders(		->setHeaders(
array(		array(
pht('Key'),		pht('Key'),
pht('Value'),		pht('Value'),
))		))
->setColumnClasses(		->setColumnClasses(
array(		array(
'pre',		'mono',
'wide',		'wide',
));		));

$constant_lists[] = $constants_table;		$constant_lists[] = $constants_table;
}		}
}		}

$table = id(new AphrontTableView($rows))		$table = id(new AphrontTableView($rows))
▲ Show 20 Lines • Show All 387 Lines • Show Last 20 Lines