Changeset View
Changeset View
Standalone View
Standalone View
src/applications/search/engine/PhabricatorSearchEngineAPIMethod.php
Show First 20 Lines • Show All 224 Lines • ▼ Show 20 Lines | foreach ($fields as $field) { | ||||
if ($constants) { | if ($constants) { | ||||
$constant_lists[] = $this->buildRemarkup( | $constant_lists[] = $this->buildRemarkup( | ||||
pht( | pht( | ||||
'Constants supported by the `%s` constraint:', | 'Constants supported by the `%s` constraint:', | ||||
'statuses')); | 'statuses')); | ||||
$constants_rows = array(); | $constants_rows = array(); | ||||
foreach ($constants as $constant) { | foreach ($constants as $constant) { | ||||
if ($constant->getIsDeprecated()) { | |||||
$is_deprecated = phutil_tag('em', array(), pht('Deprecated')); | |||||
} else { | |||||
$is_deprecated = null; | |||||
} | |||||
amckinley: Should we add a little icon in this column to match the appearance of frozen conduit methods? | |||||
$constants_rows[] = array( | $constants_rows[] = array( | ||||
$constant->getKey(), | $constant->getKey(), | ||||
$is_deprecated, | |||||
$constant->getValue(), | $constant->getValue(), | ||||
); | ); | ||||
} | } | ||||
$constants_table = id(new AphrontTableView($constants_rows)) | $constants_table = id(new AphrontTableView($constants_rows)) | ||||
->setHeaders( | ->setHeaders( | ||||
array( | array( | ||||
pht('Key'), | pht('Key'), | ||||
pht('Status'), | |||||
pht('Value'), | pht('Value'), | ||||
)) | )) | ||||
->setColumnClasses( | ->setColumnClasses( | ||||
array( | array( | ||||
'pre', | 'mono', | ||||
null, | |||||
'wide', | 'wide', | ||||
)); | )); | ||||
$constant_lists[] = $constants_table; | $constant_lists[] = $constants_table; | ||||
} | } | ||||
} | } | ||||
$table = id(new AphrontTableView($rows)) | $table = id(new AphrontTableView($rows)) | ||||
▲ Show 20 Lines • Show All 387 Lines • Show Last 20 Lines |
Should we add a little icon in this column to match the appearance of frozen conduit methods? (This is is kind of an actual consistency issue).
Or alternately, add 💚vs ❌on every row? (This is just bike-shedding).