Differential D19179 Diff 45940 src/applications/maniphest/storage/ManiphestTransaction.php

Changeset View

Standalone View

Show All 34 Lines	switch ($this->getTransactionType()) {
case ManiphestTaskEdgeTransaction::TRANSACTIONTYPE:		case ManiphestTaskEdgeTransaction::TRANSACTIONTYPE:
case ManiphestTaskUnblockTransaction::TRANSACTIONTYPE:		case ManiphestTaskUnblockTransaction::TRANSACTIONTYPE:
return false;		return false;
}		}

return parent::shouldGenerateOldValue();		return parent::shouldGenerateOldValue();
}		}

public function shouldHideForFeed() {
// NOTE: Modular transactions don't currently support this, and it has
// very few callsites, and it's publish-time rather than display-time.
// This should probably become a supported, display-time behavior. For
// discussion, see T12787.

// Hide "alice created X, a task blocking Y." from feed because it
// will almost always appear adjacent to "alice created Y".
$is_new = $this->getMetadataValue('blocker.new');
if ($is_new) {
return true;
}

return parent::shouldHideForFeed();
}

public function getRequiredHandlePHIDs() {		public function getRequiredHandlePHIDs() {
$phids = parent::getRequiredHandlePHIDs();		$phids = parent::getRequiredHandlePHIDs();

$new = $this->getNewValue();		$new = $this->getNewValue();
$old = $this->getOldValue();		$old = $this->getOldValue();

switch ($this->getTransactionType()) {		switch ($this->getTransactionType()) {
case ManiphestTaskOwnerTransaction::TRANSACTIONTYPE:		case ManiphestTaskOwnerTransaction::TRANSACTIONTYPE:
▲ Show 20 Lines • Show All 174 Lines • Show Last 20 Lines