Changeset View
Changeset View
Standalone View
Standalone View
src/applications/differential/controller/DifferentialController.php
| Show First 20 Lines • Show All 211 Lines • ▼ Show 20 Lines | foreach ($diffs as $phid => $diff) { | ||||
| if (!$legacy_messages) { | if (!$legacy_messages) { | ||||
| continue; | continue; | ||||
| } | } | ||||
| // Show the top 100 legacy lint messages. Previously, we showed some | // Show the top 100 legacy lint messages. Previously, we showed some | ||||
| // by default and let the user toggle the rest. With modern messages, | // by default and let the user toggle the rest. With modern messages, | ||||
| // we can send the user to the Harbormaster detail page. Just show | // we can send the user to the Harbormaster detail page. Just show | ||||
| // "a lot" of messages in legacy cases to try to strike a balance | // "a lot" of messages in legacy cases to try to strike a balance | ||||
| // between implementation simplicitly and compatibility. | // between implementation simplicity and compatibility. | ||||
| $legacy_messages = array_slice($legacy_messages, 0, 100); | $legacy_messages = array_slice($legacy_messages, 0, 100); | ||||
| $messages = array(); | $messages = array(); | ||||
| foreach ($legacy_messages as $message) { | foreach ($legacy_messages as $message) { | ||||
| $messages[] = HarbormasterBuildUnitMessage::newFromDictionary( | $messages[] = HarbormasterBuildUnitMessage::newFromDictionary( | ||||
| new HarbormasterBuildTarget(), | new HarbormasterBuildTarget(), | ||||
| $this->getModernUnitMessageDictionary($message)); | $this->getModernUnitMessageDictionary($message)); | ||||
| } | } | ||||
| ▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines | |||||