Differential D16981 Diff 41113 src/applications/release/OPEN_QUESTIONS

Changeset View

Standalone View

				Some questions I have that will effect this diff (Also remember to delete this
				file when done):

				- expandTransaction: Because I decided to implement "custom actions" using
				transactions (P2009), I ended up having xactions that are shown on the
				timeline ("avive has frozen this release"), but their actual work is been
				handled by another xaction ("CloseBranchTransaction"). expandTransaction is
				how the old transaction code handled this, but it didn't make it to the
				modular code.
				Should I just find a new way to do it?
				- What kind of Edges do we need? RepositoryInRelease, ?



				General questions:
				- EditEngine::buildCustomEditFields(): Why don't we move the field definitions
				into the *TransactionType classes, and then use reflection to implement this
				method? It looks like there's a 1-1 relation between fields and xaction types.



				More technical debt (For after initial dump):

				- UI for create release: like in Add Build Step, first select template, then
				fill in the rest of the stuff. Right now, I need custom create forms because I
				don't yet have Template objects.
				- None of this staff is abstracted over VCS yet - it's all git. Although this
				mostly effects terminology, because there's very little code that actually
				does things...
				- expand transaction: in a couple of cases I need to (Mostly because of the
				custom actions thing; Either move to base ApplicationEditor, or find another
				solution on my end.
				- Release Statuses are a hard-coded list right now, but should probably be
				customizable at some point.