Differential D10873 Diff 34180 src/applications/drydock/controller/DrydockLeaseViewController.php

Changeset View

Standalone View

src/applications/drydock/controller/DrydockLeaseViewController.php

Show First 20 Lines • Show All 124 Lines • ▼ Show 20 Lines	private function buildPropertyListView(
$view->addProperty(		$view->addProperty(
pht('Status'),		pht('Status'),
$status);		$status);

$view->addProperty(		$view->addProperty(
pht('Resource Type'),		pht('Resource Type'),
$lease->getResourceType());		$lease->getResourceType());

		$resource = id(new DrydockResourceQuery())
		->setViewer($this->getViewer())
		->withIDs(array($lease->getResourceID()))
		->executeOne();

		if ($resource !== null) {
$view->addProperty(		$view->addProperty(
pht('Resource'),		pht('Resource'),
$lease->getResourceID());		$this->getViewer()->renderHandle($resource->getPHID()));
		} else {
		$view->addProperty(
		pht('Resource'),
		pht('No Resource'));
		}

		epriestleyUnsubmitted Not Done Inline Actions Just use `$viewer->renderHandle()` in modern code. epriestley: Just use `$viewer->renderHandle()` in modern code.
$attributes = $lease->getAttributes();		$attributes = $lease->getAttributes();
if ($attributes) {		if ($attributes) {
$view->addSectionHeader(		$view->addSectionHeader(
pht('Attributes'), 'fa-list-ul');		pht('Attributes'), 'fa-list-ul');
foreach ($attributes as $key => $value) {		foreach ($attributes as $key => $value) {
		epriestleyUnsubmitted Not Done Inline Actions This branch is unreachable: HandleQuery never returns null. epriestley: This branch is unreachable: HandleQuery never returns null.
$view->addProperty($key, $value);		$view->addProperty($key, $value);
}		}
}		}

		epriestleyUnsubmitted Not Done Inline Actions This will render "Unknown Resource" for a lease with no resource, which I believe is possible and which seems wrong? epriestley: This will render "Unknown Resource" for a lease with no resource, which I believe is possible…
return $view;		return $view;
}		}

}		}