Differential D11870 Diff 34163 src/applications/harbormaster/engine/HarbormasterBuildEngine.php

Changeset View

Standalone View

src/applications/harbormaster/engine/HarbormasterBuildEngine.php

Show First 20 Lines • Show All 92 Lines • ▼ Show 20 Lines	public function continueBuild() {

// If we are no longer building for any reason, release all artifacts.		// If we are no longer building for any reason, release all artifacts.
if (!$build->isBuilding()) {		if (!$build->isBuilding()) {
$this->releaseAllArtifacts($build);		$this->releaseAllArtifacts($build);
}		}
}		}

private function updateBuild(HarbormasterBuild $build) {		private function updateBuild(HarbormasterBuild $build) {
		if ($build->isAborting()) {
		$this->releaseAllArtifacts($build);
		$build->setBuildStatus(HarbormasterBuild::STATUS_ABORTED);
		$build->save();
		}

if (($build->getBuildStatus() == HarbormasterBuild::STATUS_PENDING) \|\|		if (($build->getBuildStatus() == HarbormasterBuild::STATUS_PENDING) \|\|
($build->isRestarting())) {		($build->isRestarting())) {
$this->restartBuild($build);		$this->restartBuild($build);
		epriestleyUnsubmitted Not Done Inline Actions Just release the artifacts? Why are you also picking up the other restart side effects? epriestley: Just release the artifacts? Why are you also picking up the other restart side effects?
$build->setBuildStatus(HarbormasterBuild::STATUS_BUILDING);		$build->setBuildStatus(HarbormasterBuild::STATUS_BUILDING);
$build->save();		$build->save();
}		}
		epriestleyUnsubmitted Not Done Inline Actions No reason to nest these. epriestley: No reason to nest these.

if ($build->isResuming()) {		if ($build->isResuming()) {
$build->setBuildStatus(HarbormasterBuild::STATUS_BUILDING);		$build->setBuildStatus(HarbormasterBuild::STATUS_BUILDING);
$build->save();		$build->save();
}		}

if ($build->isStopping() && !$build->isComplete()) {		if ($build->isPausing() && !$build->isComplete()) {
$build->setBuildStatus(HarbormasterBuild::STATUS_STOPPED);		$build->setBuildStatus(HarbormasterBuild::STATUS_PAUSED);
$build->save();		$build->save();
}		}

$build->deleteUnprocessedCommands();		$build->deleteUnprocessedCommands();

if ($build->getBuildStatus() == HarbormasterBuild::STATUS_BUILDING) {		if ($build->getBuildStatus() == HarbormasterBuild::STATUS_BUILDING) {
$this->updateBuildSteps($build);		$this->updateBuildSteps($build);
}		}
▲ Show 20 Lines • Show All 369 Lines • Show Last 20 Lines