Differential D13534 Diff 33881 src/lint/linter/xhpast/rules/ArcanistNewlineAfterOpenTagXHPASTLinterRule.php

Changeset View

Standalone View

				<?php

				final class ArcanistNewlineAfterOpenTagXHPASTLinterRule
				extends ArcanistXHPASTLinterRule {

				const ID = 81;

				public function getLintName() {
				return pht('Newline After PHP Open Tag');
				}

				public function getLintSeverity() {
				return ArcanistLintSeverity::SEVERITY_ADVICE;
				}

				public function process(XHPASTNode $root) {
				$tokens = $root->selectTokensOfType('T_OPEN_TAG');

				foreach ($tokens as $token) {
				for ($next = $token->getNextToken();
				$next;
				$next = $next->getNextToken()) {

				if ($next->getTypeName() == 'T_WHITESPACE' &&
				preg_match('/\n\s*\n/', $next->getValue())) {
				continue 2;
				}

				if ($token->getLineNumber() != $next->getLineNumber()) {
				epriestleyUnsubmitted Not Done Inline Actions I think this phrasing is maybe a little ambiguous, since it doesn't mean "a single newline character", but could be interpreted like that (i.e. "<?php\n1+1" has "a single newline character", but is not desired). Maybe "an empty line"? epriestley: I think this phrasing is maybe a little ambiguous, since it doesn't mean "a single newline…
				break;
				}

				if ($next->getTypeName() == 'T_CLOSE_TAG') {
				continue 2;
				}
				}

				$next = $token->getNextToken();
				$this->raiseLintAtToken(
				$next,
				pht('`%s` should be separated from code by an empty line.', '<?php'),
				"\n".$next->getValue());
				}
				}

				}