Differential D13612 Diff 32970 src/applications/differential/herald/DifferentialRevisionSummaryHeraldField.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/differential/herald/DifferentialRevisionSummaryHeraldField.php
Show All 10 Lines | final class DifferentialRevisionSummaryHeraldField | ||||
public function getHeraldFieldValue($object) { | public function getHeraldFieldValue($object) { | ||||
// NOTE: For historical reasons, this field includes the test plan. We | // NOTE: For historical reasons, this field includes the test plan. We | ||||
// could maybe try to fix this some day, but it probably aligns reasonably | // could maybe try to fix this some day, but it probably aligns reasonably | ||||
// well with user expectation without harming anything. | // well with user expectation without harming anything. | ||||
return $object->getSummary()."\n\n".$object->getTestPlan(); | return $object->getSummary()."\n\n".$object->getTestPlan(); | ||||
} | } | ||||
protected function getHeraldFieldStandardConditions() { | protected function getHeraldFieldStandardType() { | ||||
return self::STANDARD_TEXT; | return self::STANDARD_TEXT; | ||||
} | } | ||||
public function getHeraldFieldValueType($condition) { | |||||
return HeraldAdapter::VALUE_TEXT; | |||||
} | |||||
} | } |