Differential D10593 Diff 25468 src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php
| Show All 23 Lines | public function getConfiguration() { | ||||
| return array( | return array( | ||||
| self::CONFIG_AUX_PHID => true, | self::CONFIG_AUX_PHID => true, | ||||
| self::CONFIG_SERIALIZATION => array( | self::CONFIG_SERIALIZATION => array( | ||||
| 'details' => self::SERIALIZATION_JSON, | 'details' => self::SERIALIZATION_JSON, | ||||
| ), | ), | ||||
| self::CONFIG_COLUMN_SCHEMA => array( | self::CONFIG_COLUMN_SCHEMA => array( | ||||
| 'className' => 'text255', | 'className' => 'text255', | ||||
| 'sequence' => 'uint32', | 'sequence' => 'uint32', | ||||
| 'name' => 'text255', | |||||
| 'description' => 'text', | 'description' => 'text', | ||||
| // T6203/NULLABILITY | |||||
| // This should not be nullable. Current `null` values indicate steps | |||||
| // which predated editable names. These should be backfilled with | |||||
hach-que: This is null because of previously existing build steps in the DB before name was added. In… | |||||
| // default names, then the code for handling `null` shoudl be removed. | |||||
| 'name' => 'text255?', | |||||
| ), | ), | ||||
| self::CONFIG_KEY_SCHEMA => array( | self::CONFIG_KEY_SCHEMA => array( | ||||
| 'key_plan' => array( | 'key_plan' => array( | ||||
| 'columns' => array('buildPlanPHID'), | 'columns' => array('buildPlanPHID'), | ||||
| ), | ), | ||||
| ), | ), | ||||
| ) + parent::getConfiguration(); | ) + parent::getConfiguration(); | ||||
| } | } | ||||
| ▲ Show 20 Lines • Show All 88 Lines • Show Last 20 Lines | |||||
This is null because of previously existing build steps in the DB before name was added. In this case, null means "fallback to the implementation name".
In order to remove this null, we'd need to run a migration to fill in all the null values with the implementation name.