Page MenuHomePhabricator

Mark questionable column nullability for later
ClosedPublic

Authored by epriestley on Sep 27 2014, 11:48 PM.

Details

Summary

Ref T1191. Ref T6203. While generating expected schemata, I ran into these columns which seem to have sketchy nullability.

  • Mark most of them for later resolution (T6203). They work fine today and don't need to block T1191. Changing them can break the application, so we can't autofix them.
  • Forgive a couple of them that are sort-of reasonable or going to get wiped out.
Test Plan

Saw 94 remaining warnings.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Mark questionable column nullability for later.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
hach-que added inline comments.
src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php
36

This is null because of previously existing build steps in the DB before name was added. In this case, null means "fallback to the implementation name".

In order to remove this null, we'd need to run a migration to fill in all the null values with the implementation name.

btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 30 2014, 4:53 PM
epriestley edited edge metadata.
This revision was automatically updated to reflect the committed changes.