Differential D8801 Diff 20892 src/workflow/ArcanistLandWorkflow.php

Changeset View

Standalone View

src/workflow/ArcanistLandWorkflow.php

Show First 20 Lines • Show All 527 Lines • ▼ Show 20 Lines	$message = $this->getConduit()->callMethodSynchronous(
'revision_id' => $rev_id,		'revision_id' => $rev_id,
));		));

$this->messageFile = new TempFile();		$this->messageFile = new TempFile();
Filesystem::writeFile($this->messageFile, $message);		Filesystem::writeFile($this->messageFile, $message);

echo pht("Landing revision '%s'...",		echo pht("Landing revision '%s'...",
"D{$rev_id}: {$rev_title}"), "\n";		"D{$rev_id}: {$rev_title}"), "\n";

		$diff_phid = idx($this->revision, 'activeDiffPHID');
		if ($diff_phid) {
		$this->checkForBuildables($diff_phid);
		}
}		}

private function pullFromRemote() {		private function pullFromRemote() {
$repository_api = $this->getRepositoryAPI();		$repository_api = $this->getRepositoryAPI();

$local_ahead_of_remote = false;		$local_ahead_of_remote = false;
if ($this->isGit) {		if ($this->isGit) {
$repository_api->execxLocal('checkout %s', $this->onto);		$repository_api->execxLocal('checkout %s', $this->onto);
▲ Show 20 Lines • Show All 613 Lines • ▼ Show 20 Lines	if ($this->isGit) {
$repository_api->execxLocal(		$repository_api->execxLocal(
'submodule update --init --recursive');		'submodule update --init --recursive');
}		}
echo phutil_console_format(		echo phutil_console_format(
"Switched back to {$this->branchType} %s.\n",		"Switched back to {$this->branchType} %s.\n",
$this->oldBranch);		$this->oldBranch);
}		}


		/**
		* Check if a diff has a running or failed buildable, and prompt the user
		* before landing if it does.
		*/
		private function checkForBuildables($diff_phid) {
		// NOTE: Since Harbormaster is still beta and this stuff all got added
		// recently, just bail if we can't find a buildable. This is just an
		// advisory check intended to prevent human error.
		btrahanUnsubmitted Not Done Inline Actions I would guess this is still what we do even when harbormaster is out of beta. btrahan: I would guess this is still what we do even when harbormaster is out of beta.
		epriestleyAuthorUnsubmitted Not Done Inline Actions Yeah -- if there's another version bump in the future we could theoretically adjust this a bit, but you're probably right. epriestley: Yeah -- if there's another version bump in the future we could theoretically adjust this a bit…

		try {
		$buildables = $this->getConduit()->callMethodSynchronous(
		'harbormaster.querybuildables',
		array(
		'buildablePHIDs' => array($diff_phid),
		'manualBuildables' => false,
		));
		} catch (ConduitClientException $ex) {
		return;
		}

		if (!$buildables['data']) {
		// If there's no corresponding buildable, we're done.
		return;
		}

		$console = PhutilConsole::getConsole();

		$buildable = head($buildables['data']);

		if ($buildable['buildableStatus'] == 'passed') {
		$console->writeOut(
		"<bg:green> %s </bg> %s\n",
		pht('BUILDS PASSED'),
		pht(
		'Harbormaster builds for the active diff completed successfully.'));
		return;
		}

		switch ($buildable['buildableStatus']) {
		case 'building':
		$message = pht(
		'Harbormaster is still building the active diff for this revision:');
		$prompt = pht('Land revision anyway, despite ongoing build?');
		break;
		case 'failed':
		$message = pht(
		'Harbormaster failed to build the active diff for this revision. '.
		'Build failures:');
		$prompt = pht('Land revision anyway, despite build failures?');
		break;
		default:
		// If we don't recognize the status, just bail.
		return;
		}

		$builds = $this->getConduit()->callMethodSynchronous(
		'harbormaster.querybuilds',
		array(
		'buildablePHIDs' => array($buildable['phid']),
		));

		$console->writeOut($message."\n\n");
		foreach ($builds['data'] as $build) {
		switch ($build['buildStatus']) {
		case 'failed':
		$color = 'red';
		break;
		default:
		$color = 'yellow';
		break;
		}

		$console->writeOut(
		" <bg:".$color."> %s </bg> %s: %s\n",
		phutil_utf8_strtoupper($build['buildStatusName']),
		pht('Build %d', $build['id']),
		$build['name']);
		}

		$console->writeOut(
		"\n%s\n\n %s: __%s__",
		pht('You can review build details here:'),
		pht('Harbormaster URI'),
		$buildable['uri']);

		if (!$console->confirm($prompt)) {
		throw new ArcanistUserAbortException();
		}
		}

}		}