Page MenuHomePhabricator

Hiding inline comments confuses keyboard navigation shortcuts
Closed, DuplicatePublic

Description

I was navigating through a large review using the n keyboard shortcut to move between inline comments. I hid a few comments and continued to move through the review, but as soon as I used p to navigate back, the view jumped around somewhat randomly.

I played around a bit, and it seems like the positions used by n and p weren't updated to reflect the hidden comments. My expectation was that those shortcuts would continue to move me between the current set of visible comments.

Event Timeline

jparise raised the priority of this task from to Needs Triage.
jparise updated the task description. (Show Details)
jparise added a project: Differential.
jparise added a subscriber: jparise.