Page MenuHomePhabricator

Some VCS commands may bleed upward out of instances to affect `core/`
Closed, InvalidPublic

Description

In the cluster setup, we sometimes run commands like git remote set-url origin ... in instance repositories. These may not be valid Git repositories, but commands like git status will still work because they're subdirectories of core/, so git remote set-url ... can affect core/. Before adjusting origins, we should verify that the git root is where we expect it to be.

Event Timeline

epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added projects: Diffusion, Phacility.
epriestley added a subscriber: epriestley.

Something changed an origin URL for me locally, but I can't figure out how it happened so it might have been a fluke and/or me being dumb.

In the code, I can't find a codepath which runs git remote set-url without first having a valid working copy, and I can't reproduce it by banging on things.