Page MenuHomePhabricator
Differential D10746

Diffusion - fix another commit importing case.
ClosedPublic
Actions

Authored by btrahan on Oct 27 2014, 7:11 PM.
Tags
None
Referenced Files
F15483186: D10746.id.diff
Wed, Apr 9, 10:29 AM
F15459311: D10746.id25794.diff
Mon, Mar 31, 11:51 AM
F15453583: D10746.id25795.diff
Sat, Mar 29, 12:48 PM
F15451396: D10746.id.diff
Fri, Mar 28, 9:51 PM
F15446286: D10746.diff
Thu, Mar 27, 6:12 PM
F15425234: D10746.id25794.diff
Mar 23 2025, 3:25 AM
F15420807: D10746.id25794.diff
Mar 21 2025, 5:51 PM
F15378210: D10746.id25794.diff
Mar 13 2025, 1:29 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T6350: Diffusion spamming the feed/commits going weird
T6395: Daemon crashes parsing empty commit
Commits
Restricted Diffusion Commit
rP0dcc4132bec6: Diffusion - fix another commit importing case.
Summary

Fixes T6395. Ref T6350. I guess I missed this code spot in prior testing / I definitely didn't run an empty commit through it. Works now though.

Test Plan

made an empty commit and observed stuck importing status and errors in phd log. applied patch and commit successfully imported with no errors. made another empty commit and it imported as well

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 25794.Oct 27 2014, 7:11 PM
btrahan added tasks: T6395: Daemon crashes parsing empty commit, T6350: Diffusion spamming the feed/commits going weird.
btrahan retitled this revision from to Diffusion - fix another commit importing case..
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 27 2014, 7:11 PM
Harbormaster completed remote builds in B2889: Diff 25794.Oct 27 2014, 7:12 PM
epriestley accepted this revision.Oct 27 2014, 7:13 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 27 2014, 7:13 PM
Closed by commit rP0dcc4132bec6: Diffusion - fix another commit importing case. (authored by btrahan, committed by btrahan). · Explain WhyOct 27 2014, 7:19 PM
This revision was automatically updated to reflect the committed changes.
chad mentioned this in T7043: Cannot import commit into Diffusion .Jan 26 2015, 6:06 PM

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
data/
11 lines
query/
lowlevel/
7 lines

Diff 25795

View Options

src/applications/diffusion/data/DiffusionCommitHash.php

Loading...
View Options

src/applications/diffusion/query/lowlevel/DiffusionLowLevelCommitFieldsQuery.php

Loading...
Phabricator · Built by Phacility