Page MenuHomePhabricator
Create Task
Maniphest T6778

Herald/Legalpad rule didn't apply to D11007
Closed, ResolvedPublic
Actions

Description

Seems like it should have?

Event Timeline

chad created this task.Dec 18 2014, 4:04 AM
chad raised the priority of this task from to Needs Triage.
chad updated the task description. (Show Details)
chad added projects: Herald, Restricted Project.
chad added subscribers: chad, epriestley.
chad added a comment.Dec 18 2014, 4:12 AM

https://secure.phabricator.com/herald/transcript/62438/
https://secure.phabricator.com/D11007

epriestley added a comment.Dec 18 2014, 11:52 AM

The author has already signed the agreement. The rule has no effect for authors who have already signed.

Maybe the "Required signatures." is confusing? It means "Required (any missing) signatures."

chad closed this task as Resolved.Dec 18 2014, 2:48 PM
chad claimed this task.

Ah ok, I thought it'd still be attached (but state signed or something).

epriestley added a comment.Dec 18 2014, 2:50 PM

Not showing an indicator for the empty state is a bit inconsistent with other production decisions, but my reasoning was that if we always show "<author> already signed stuff" then 99% of diffs (i.e., those created by repeat users) will have it and it won't be useful on them. This felt a bit more like a warning that we only need to show when there's a problem to me.

Phabricator · Built by Phacility