Page MenuHomePhabricator

Added files should take up the entire diff pane
Closed, DuplicatePublic

Description

Currently in Differential and Diffusion added and removed files occupy ½ of the diff viewer space, with the other one being completely empty. It would be great if they took up the entire space and were marked red or green based on their added/deleted state.

Event Timeline

anton.vladimirov raised the priority of this task from to Needs Triage.
anton.vladimirov updated the task description. (Show Details)
anton.vladimirov added a subscriber: anton.vladimirov.

This feels confusing to me, since left is old and right is new, we then have that paradigm broken and the viewer has to look for other queues as to what the actual change is.

What problem do you feel this is solving?

On smaller screens longer lines wrap unnecessarily, which causes the file to potentially occupy much more room on the page.

~Anton

Can you provide a screenshot of the issue?

epriestley claimed this task.

We don't plan to pursue this. We do plan to implement a unified diff view (1-up for the entire diff instead of 2-up) which will help with smaller screens.

I’m assuming from @epriestley’s comment that the issue is understood without a screenshot, so I won’t bother with it unless you guys still want it.

I don’t think this is duped right, though, since it’s not the same issue as 1-up support. This specifically requests a special case in 2-up for diffs that have no “other” part. I would call it a won’t fix based on the comment, but you guys know better how to manage your own tasks.