Page MenuHomePhabricator

Make "Password for Key" field optional
Closed, InvalidPublic

Description

When creating new credential of SSH Private Key type, than Password for Key field is always required. However at key generation time you can also specify an empty password and you can't really use that key in Phabricator.

Also I wonder why the regular Password credential can't be used with repositories having svn+ssh:// in their path.

Event Timeline

aik099 raised the priority of this task from to Needs Triage.
aik099 updated the task description. (Show Details)
aik099 added a subscriber: aik099.

I can't reproduce this. I'm able to create a private key without a password without any problems -- just don't type anything into the box. It isn't marked required in the UI.

Also I wonder why the regular Password credential can't be used with repositories having svn+ssh:// in their path.

We don't plan to support this. SSH + Password auth is very rare and less secure than SSH + Key.

I start credential creation from repository editing screen. Maybe that matters. Here is the workflow:

  1. my repo has file:// protocol before and now I've changed it to svn+ssh://
  2. on next screen select to create new credential
  3. then I see that private key field isn't required (that's unusual) but Password for Key field is required
  4. I paste private key in
  5. submit the form

And I'm asked to provide value for private key password (because required word was displayed next to that field)

Can you upload an example of a key which exhibits this issue (presumably not an important key which you actually use for anything)? I still can't reproduce it.

Unfortunately I use that key, so I can't upload it. I've chosen to use Private Key, that Phabricator generated for now. Feel free to close this task then.

epriestley claimed this task.