Page MenuHomePhabricator

Undepricate "diffusion.createcomment" Conduit API call
Closed, WontfixPublic

Description

The diffusion.createcomment Conduit API call was added in D6923 as deprecated (no idea why except, that @epriestley asked it back then). The only concern back then with that API call was that it doesn't support transactions.

Now it does, and works normally: https://secure.phabricator.com/diffusion/P/browse/master/src/applications/diffusion/conduit/DiffusionCreateCommentConduitAPIMethod.php

Can you please undepricate it?

Another useful thing can be adding identifier input parameter (optional). This would allow adding comments to commits by their id, e.g. "rABC434346", rather than doing a search first to get PHID of commit and then using it in 2nd API call to add a comment.

I already have a code at hand for that change and can submit it.

Event Timeline

aik099 created this task.Nov 4 2014, 1:09 PM
aik099 raised the priority of this task from to Needs Triage.
aik099 updated the task description. (Show Details)
aik099 added a project: Diffusion.
aik099 added a project: Conduit.
aik099 added a subscriber: aik099.
epriestley closed this task as Wontfix.Nov 4 2014, 1:15 PM
epriestley claimed this task.

See T5873.

aik099 added a comment.Nov 4 2014, 1:20 PM

As we've already discussed that task is far from it's implementation. Until then current API call works, why mark it as deprecated and prevent anybody willing to add comment to commit from seeing that call on /conduit/ page. I guess deprecation status only affects visibility of that API call, but it still continues to work.