Page MenuHomePhabricator
Create Task
Maniphest T6449

The "svn:externals" aren't covered by unit tests
Closed, WontfixPublic
Actions

Description

The currently used SVN repository fixture doesn't have any SVN externals configured, nor they are asserted in unit tests.

This in turn allowed the T6447 to exist without being noticed for some time.

Related Objects

Event Timeline

aik099 created this task.Nov 1 2014, 9:22 PM
aik099 raised the priority of this task from to Needs Triage.
aik099 updated the task description. (Show Details)
aik099 added a project: Arcanist.
aik099 added a subscriber: aik099.
epriestley closed this task as Wontfix.Nov 1 2014, 11:33 PM
epriestley claimed this task.

Lots of stuff isn't covered by unit tests. We don't aim to have 100% coverage.

aik099 added a comment.EditedNov 2 2014, 8:02 AM

That's reassuring statement :)

You might want to keep this task open, so anybody volunteering to add these tests (like me for example, if I figure out how) will be aware that they are needed.

Phabricator · Built by Phacility