Page MenuHomePhabricator

Allow creating diff from SVN projects with changed externals
Closed, WontfixPublic

Description

Right now when I run arc diff command on an SVN working copy, that makes use of "svn:externals" property and has one of files/folders in these externals modified I get this warning (both "tools" and "core" folders come from externals):

The working copy includes changes to 'svn:externals' paths. These changes will not be included in the diff because SVN can not commit 'svn:externals' changes alongside normal changes.

Modified 'svn:externals' files:

        core/kernel/tests
        tools/build
        tools/build/inc
        tools/build/targets

    Generate a diff (with just local changes) anyway? [y/N]

That's ok, but if I select "N" (that to me means to generate diff that includes changes in externals as well) I've got this:

Usage Exception: User aborted the workflow.

I think it's wrong to consider patch build of local + external changes as an error. For example user who will run arc patch will have same externals checked out and that patch will be applied without any issues.

Event Timeline

aik099 raised the priority of this task from to Needs Triage.
aik099 updated the task description. (Show Details)
aik099 added a project: Arcanist.
aik099 added a subscriber: aik099.
epriestley claimed this task.

We don't plan to support this. A change including externals can not be committed in a single transaction, and there is very little interest in support for externals.

If people are using arc land to do a commit. Although reading documentation I've noticed that nobody is forced to use arc land and can commit in any way they want.

Usually I just hit Ctrl+C to abort whatever I don't like. I was surprised to get exception when I've answered N in that arc prompt.