Page MenuHomePhabricator

Indigo looks pink in base ui colors
Closed, ResolvedPublic

Description

In the base set of colors "indigo" renders as pink. Consider moving it to pink and creating correct indigo color.


The icon color pink is missing in remarkup, all other colours used inside projects are working

Working

Broken

The following class is missing from phui-font-icon-base.css

.phui-icon-view.pink

The value pink is also missing from the method getFontIconColors inside

phabricator/src/view/phui/PHUIIconView.php

Event Timeline

bajb raised the priority of this task from to Normal.
bajb updated the task description. (Show Details)
bajb added projects: Badge Awarded, Remarkup.
bajb added a subscriber: bajb.

This is intentional, as pink is not a base ui color in Phabricator (and neither is checkered). Is there a reason you need it for Remarkup?

Specifically, projects can be added via hashtags (#) for Remarkup purposes.

In our wiki of how projects should be labeled, coloured etc, we have icons to define the type, and then the colour to define a group.

So briefcase icons are to define applications within the project, and colours are to define the group, so green would be for support, blue for billing etc.

This falls over where we say a green briefcase should be support applications, as a generic grouping, without having to create a stub project, for the purposes of a wiki/note.

We do use the hastags already, but our docs look a little silly saying have a pink briefcase, when its showing as grey.

More of an annoyance than anything else.

We don't intend to provide this, we maintain two different color palettes for "tags" and "icons". I would recommend using indigo instead to match the pink in tags, which, is more pink than indigo anyways.

https://secure.phabricator.com/uiexample/view/PHUIIconExample/

chad renamed this task from Pink Icon Colour Missing to Indigo looks pink in base ui colors.Oct 14 2014, 5:13 PM
chad lowered the priority of this task from Normal to Low.
chad updated the task description. (Show Details)
chad added a project: Design.
chad removed a subscriber: qgil.

I'm going to triage this to fixing indigo anyways.

(and I will add pink then) ?