Page MenuHomePhabricator

Text lint checker for tabs should only check changed lines
Closed, ResolvedPublic

Description

The default 'text' linter has warnings for tabs in a file. However, unlike the messages for max-line-length, which do not complain about long lines in lines not touched by the commit, the tab lint complains about tabs anywhere in the file. This is pretty annoying, and at least should be configurable.

Event Timeline

ezyang raised the priority of this task from to Needs Triage.
ezyang updated the task description. (Show Details)
ezyang added a project: Arcanist.
ezyang added a subscriber: ezyang.
epriestley claimed this task.

See "Adjusting Message Severities" here for instructions on adjusting the severity:

https://secure.phabricator.com/book/phabricator/article/arcanist_lint/

To clarify, the severity determines whether or not the error is reported always, or only if it was touched by the commit.

I wonder if tabs should really be considered ERROR by default.