Page MenuHomePhabricator
Create Task
Maniphest T5958

Permanently fail Feed HTTP tasks if the URI has been removed
Closed, ResolvedPublic
Actions

Description

Feed HTTP tasks retry forever, but if they don't 200 on the endpoint they should check if the URI is still present in configuration. If it has been removed, they should permanently fail.

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Event Timeline

epriestley created this task.Aug 25 2014, 6:30 AM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added projects: Feed, Daemons.
epriestley added a subscriber: epriestley.
rfergu added a subscriber: rfergu.Aug 25 2014, 6:34 AM
epriestley assigned this task to btrahan.Aug 25 2014, 1:17 PM
  • In FeedPublisherHTTPWorker, before making the request, pull feed.http-hooks from config.
  • If the URI is no longer present, throw PhabricatorWorkerPermanentFailureException to permanently fail the request.
btrahan added a revision: Restricted Differential Revision.Aug 26 2014, 9:32 PM
btrahan closed this task as Resolved.Aug 26 2014, 10:02 PM
btrahan added a commit: Restricted Diffusion Commit.

Closed by commit rP7cdee1884ec8.

Phabricator · Built by Phacility