Page MenuHomePhabricator

Redirect to HTTPS from HTTP fails because "not marked external"
Closed, ResolvedPublic

Description

Previously, whenever we opened Phabricator through HTTP (e.g. http://phabricator.company.tld) it would redirect us to the glorious safe haven of HTTPS (e.g. https://phabricator.company.tld).

Now however, Phabricator refuses to lead us to the shiny gates of TLS with the following error:

[Rendering Exception/Exception] Refusing to redirect to local resource "https://phabricator.company.tld/".
The URI has a domain, but the redirect is not marked external. Mark redirects as external to allow redirection off the local domain.

Suggested fix: whitelist redirects to the phabricator.base-uri setting.

Event Timeline

GMTA raised the priority of this task from to Needs Triage.
GMTA updated the task description. (Show Details)
GMTA added a project: Phabricator.
GMTA added a subscriber: GMTA.
hach-que added a subscriber: epriestley.

I've attached a fix for @epriestley to review when he's online. If you could verify that it fixes the issue for your install in the mean time, that'd be appreciated.

I just tested your diff on our installation and it works perfectly. Thanks!