Page MenuHomePhabricator

PhabricatorBotMacroHandler handling of image lookup failures lacks grace
Closed, ResolvedPublic

Description

rasterize can potentially return false (if HTTPSFuture::loadContent does), but this potential boolean value is not checked before passing it along to a foreach loop.

Revisions and Commits

Restricted Differential Revision

Event Timeline

cburroughs raised the priority of this task from to Needs Triage.
cburroughs updated the task description. (Show Details)
cburroughs added a project: Phabot.
cburroughs added a subscriber: cburroughs.
epriestley added a revision: Restricted Differential Revision.Aug 14 2014, 3:37 PM
epriestley added a commit: Restricted Diffusion Commit.

Closed by commit rP40a4eeec77a9.