Page MenuHomePhabricator

Option "differential.allow-self-accept" has no effect in Diffusion
Closed, WontfixPublic

Description

The "differential.allow-self-accept" option in Diffusion (default to false by the way) specifies if user can accept commit that he made.

It turns out however, that it has no effect and that user still sees "Accept Commit" in dropdown before comment textarea in the bottom of his own commit.

Even though option has "differential" in it's name, but it has affected the Diffusion commits being audited as well. Now it doesn't.

Event Timeline

aik099 raised the priority of this task from to Needs Triage.
aik099 updated the task description. (Show Details)
aik099 added a project: Differential.
aik099 added a subscriber: aik099.
aik099 renamed this task from Option "differential.allow-self-accept" has no effect to Option "differential.allow-self-accept" has no effect in Diffusion.Jul 29 2014, 8:13 AM
aik099 updated the task description. (Show Details)
aik099 edited projects, added Diffusion; removed Differential.
epriestley claimed this task.

This option does not affect Diffusion and never has.

audit.can-author-close-audit provides somewhat similar functionality.