Page MenuHomePhabricator

Pholio control+enter renders a 404 on inline comment submission and edit.
Closed, ResolvedPublic

Description

When submitting or editing an inline comment in Pholio, submitting the form by pressing control+enter leads to a 404 page. Using the mouse to click the submit button works as expected.

It looks like the cause of this is that control+enter is not sending all of the form data to the controller. When I inspect the POST request with firebug, I see this when I click on submit:

__csrf__=B%40vlb7lf3n5fb421dbaac05034&__form__=1&op=save&text=Hello%20world!&mockID=1&imageID=1&startX=158&startY=155.68333435058594&endX=255&endY=284.68333435058594&__wflow__=true&__ajax__=true&__metablock__=9

... but I see this when I hit control+enter:

__csrf__=B%40a4nj5mw25ddc3e7fbf152630&__form__=1&op=save&text=Hello+world%21

I am seeing this behavior in both Firefox and Chrome.

Event Timeline

codeblock raised the priority of this task from to Normal.
codeblock updated the task description. (Show Details)
codeblock added a project: Pholio.
codeblock added a subscriber: codeblock.
epriestley claimed this task.

D9537 swapped this over (at least temporarily) to standard dialogs, and they appear to work as expected.