Page MenuHomePhabricator

PhabricatorPolicyDataTestCase::testProjectPolicyMembership unit test fails due to new 'icon' column
Closed, ResolvedPublic

Description

As part of an new automatic Phabricator deployment process, we're running arc unit --everything on each repo. I've noticed this one appearing, which is presumably happening due to the test not being updated to handle the new project icons column.

   FAIL  PhabricatorPolicyDataTestCase::testProjectPolicyMembership
EXCEPTION (AphrontQueryException): #1048: Column 'icon' cannot be null
#0 /srv/phabricator/libphutil/src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnectionBase.php(278): AphrontMySQLDatabaseConnectionBase->throwQueryCodeException(1048, 'Column 'icon' c...')
#1 /srv/phabricator/libphutil/src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnectionBase.php(184): AphrontMySQLDatabaseConnectionBase->throwQueryException(Object(mysqli))
#2 /srv/phabricator/libphutil/src/xsprintf/queryfx.php(9): AphrontMySQLDatabaseConnectionBase->executeRawQuery('INSERT INTO `pr...')
#3 [internal function]: queryfx(Object(AphrontMySQLiDatabaseConnection), '%Q INTO %T (%LC...', 'INSERT', 'project', Array, ''A', '0', 'PHID...')
#4 /srv/phabricator/libphutil/src/aphront/storage/connection/AphrontDatabaseConnection.php(28): call_user_func_array('queryfx', Array)
#5 /srv/phabricator/phabricator/src/infrastructure/storage/lisk/LiskDAO.php(1282): AphrontDatabaseConnection->query('%Q INTO %T (%LC...', 'INSERT', 'project', Array, ''A', '0', 'PHID...')
#6 /srv/phabricator/phabricator/src/infrastructure/storage/lisk/LiskDAO.php(1129): LiskDAO->insertRecordIntoDatabase('INSERT')
#7 /srv/phabricator/phabricator/src/infrastructure/storage/lisk/LiskDAO.php(1098): LiskDAO->insert()
#8 /srv/phabricator/phabricator/src/applications/policy/__tests__/PhabricatorPolicyDataTestCase.php(17): LiskDAO->save()
#9 [internal function]: PhabricatorPolicyDataTestCase->testProjectPolicyMembership()
#10 /srv/phabricator/arcanist/src/unit/engine/phutil/ArcanistPhutilTestCase.php(486): call_user_func_array(Array, Array)
#11 /srv/phabricator/arcanist/src/unit/engine/PhutilUnitTestEngine.php(60): ArcanistPhutilTestCase->run()
#12 /srv/phabricator/arcanist/src/workflow/ArcanistUnitWorkflow.php(173): PhutilUnitTestEngine->run()
#13 /srv/phabricator/arcanist/scripts/arcanist.php(322): ArcanistUnitWorkflow->run()
#14 {main}

Revisions and Commits

Event Timeline

hach-que assigned this task to epriestley.
hach-que raised the priority of this task from to Needs Triage.
hach-que updated the task description. (Show Details)
hach-que added a project: Phabricator.
hach-que added a subscriber: hach-que.
Unknown Object (User) edited this Maniphest Task.May 29 2014, 12:45 PM
Unknown Object (User) closed this task as Resolved.May 29 2014, 12:45 PM

Closed by commit rPb20142c0febe.