Page MenuHomePhabricator

Push log doesn't handle pushes with > 2 commits
Closed, ResolvedPublic

Description

We have a global rule set up in Herald to email project members for each repository push. Whenever the push contains more than 2 commits the email only includes 2 of those commits.

The diffusion/pushlog is also affected. The push log page only shows 2 of the commits. If you view the push log list page it will show multiple rows for the same push number but all link to the same page.

See screenshots below:

Pushed 8 changesets:

{F161270}

Notification email only says 2:

{F161264}

Push log web page lists multiples:

{F161268}

Event Timeline

jpoehls raised the priority of this task from to Needs Triage.
jpoehls updated the task description. (Show Details)
jpoehls added projects: Herald, Diffusion.
jpoehls added subscribers: jpoehls, rbanderton.

Thanks for the report! D9309 should fix this. (D9308 fixes an unrelated bug I hit while reproducing this.)

(My co-worker just had a baby last night so these might take a little longer than usual to land in HEAD.)

epriestley triaged this task as Normal priority.
epriestley edited this Maniphest Task.