Page MenuHomePhabricator

Move Dashboard and Panel edit history out of the way
Closed, ResolvedPublic

Description

  • Dashboard edit history currently appears on the "Manage" view, between the details and the arrangeable dashboard. However, this data is rarely very interesting. Move it to a separate page, and add an "Edit History" link to the links on the right in order to get to it.
  • Panel edit history currently appears between the details and the panel, on panel detail pages. Here, maybe just move it under the panel?

Event Timeline

epriestley assigned this task to lpriestley.
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Dashboards.
epriestley added a subscriber: epriestley.

Just to clarify, we're not editing history, so I think we should name it something else... maybe "View History"?

I also would think that once we have a workflow where panels will most likely be created from within a dashboard, they will also most often be edited from within a dashboard. In that context, wouldn't it be helpful to include panel history along with the dashboard history that the panel belongs to?

My guess is that most users looking at panel histories want to answer a very specific question ("Who screwed up my panel? I want to punch that jerk..."), not get a more general understanding of how the dashboard has been updated over time ("What are all the changes which have affected this dashboard? I want to reminisce about old times...").

If we combined all of the events (so there's a single timeline of the dashboard and all of its panels) it could be difficult to find the events you care about ("Who screwed up my panel?") because they'd be intermingled in a larger stream of unrelated events. With panel history attached to panels, you can go directly to the panel that someone screwed up and see who did it. I'm not sure this would really be so bad since there probably won't be tons and tons of events, but I could imagine it making it slower to answer the "Who screwed stuff up?" question.

We could separate the histories instead, so the page showed the edit history of the dashboard and then the individual histories of the panels, but this would probably take about as long to sort through as just clicking to the panel in the first place.

These approaches are also both nonstandard, in that we don't have any other UIs which show the histories of several objects on a single page.

Overall:

  • Any of these approaches would probably work fine.
  • My guess is that separate histories serve the most common use case ("Who made this specific edit?") slightly better, although this is only a guess.
  • Separate histories are also most consistent with other applications. We could deviate, but I'd prefer a stronger use case motivating the deviation.