Page MenuHomePhabricator

Highlight and preselect delta diff based on last reviewer's comment
Closed, WontfixPublic

Description

Right now, it shows diff between first arc diff and last arc diff. Comments from reviewers are lost in between. It would be nice if Differential pre-selected last diff with comments and last arc diff call. Either that, or highlight arc diff calls with review comments.

For example: D9140: Allow dashboard panels to detect rendering cycles and arrest stack overflows. Say @epriestley (author) or @btrahan (reviewer) opened the revision after @epriestley had sent the last arc diff. They would be most likely interested in viewing https://secure.phabricator.com/D9140?vs=21708&id=21727 rather than https://secure.phabricator.com/D9140. For everybody else, full diff should be fine.

Event Timeline

igorgatis raised the priority of this task from to Needs Triage.
igorgatis updated the task description. (Show Details)
igorgatis added a project: Differential.
igorgatis added a subscriber: igorgatis.
epriestley claimed this task.

There is a link in the email to jump directly to the changes:

Screen_Shot_2014-05-16_at_4.39.55_AM.png (267×438 px, 33 KB)

The proposed rule is too complicated and magical in cases where there are multiple reviewers, multiple state changes, etc. I don't think we could get it right all the time.

We do intend to improve tracking of inline comments, see T1460.

AFAIK rietveld/gerrit has something like this.

The link to comment fails to me sometimes. I'll further investigate but it seems that when there are too many files and they take some time "loading", the browser does not jump to the comment and I have to find the comment myself.