Page MenuHomePhabricator

Unable To Add Credential
Closed, ResolvedPublic

Description

I tried to add a credential in Passphrase but get the following error:

Undefined variable: v_is_unlocked

Further investigation shows that Passphrase is trying to read whether or not a credential is locked permanently when generating the form for creating a new credential.

The following is my attempt at a fix:

diff --git a/src/applications/passphrase/controller/PassphraseCredentialEditController.php b/src/applications/passphrase/controller/PassphraseCredentialEditController.php
index 92b62b8..3b8395a 100644
--- a/src/applications/passphrase/controller/PassphraseCredentialEditController.php
+++ b/src/applications/passphrase/controller/PassphraseCredentialEditController.php
@@ -292,7 +292,7 @@ final class PassphraseCredentialEditController extends PassphraseController {
             'lock',
             1,
             pht('Lock Permanently'),
-            $v_is_locked)
+            $credential_is_locked)
           ->setDisabled($credential_is_locked));
     }

Event Timeline

marklu raised the priority of this task from to Needs Triage.
marklu updated the task description. (Show Details)
marklu added a project: Passphrase.
marklu added a subscriber: marklu.
epriestley claimed this task.

Thanks, this should be fixed in HEAD (rPca6b821c). Let us know if you run into anything else!